Would it be possible to filter verbs and adjectives? I really would like to train those sometimes, especially the readings.
I think that information is included in the API, but I’m not actively adding features to this script. @prouleau, do any of your filter scripts include a part of speech option?
I didn’t write this one but @rfindley wrote a Part of Speech filter that does exactly this. It is available as an optional filter in Item Inspector. This is the preferred way to run it if you use Item Inspector. Otherwise it can also be installed as a standalone filter at the link here.
Cool, thanks for the Help.
Hey guys, I am studying for JLPT, and I use the aditional filter and omega reorder and it works briliantly, but some radicals, like zombie, don’t have the radical in the resource so I can’t add it to related items. Is there some way to add specific radicals add them by radical name or something? Any helps would be really appreciated.
Maybe try [Item List Filter]. It’s designed for Self-Study Quiz, but it should work with Reorder Omega, too.
@seanblue There are bugs in the code to select accelerated srs. The bug is the level property is located in item.data, not item. assignment. This bug happens to process regular srs interval properly but it fails to recognise accelerated srs.
line 294 should be changed from
294 var level = item.assignment.level;
to
294 var level = item.data.level;
Also line 349 must be changed from
349 var srsInvervalInHours = getSrsIntervalInHours(srsStage, assignments.level);
to
349 var srsInvervalInHours = getSrsIntervalInHours(srsStage, item.data.level);
Was there a breaking API change recently or something? What you’re saying is basically that this has been broken for years or never worked, which would be surprising.
No it is not a change in the API. I checked that and the API data is correct.
The consequence of the problem is in this code:
var regularSrsIntervals = [0, 4, 8, 23, 47, 167, 335, 719, 2879];
var acceleratedSrsIntervals = [0, 2, 4, 8, 23, 167, 335, 719, 2879];
var acceleratedLevels = [1, 2];
function getSrsIntervalInHours(srsStage, level) {
var srsInvervals = acceleratedLevels.includes(level) ? acceleratedSrsIntervals : regularSrsIntervals;
return srsInvervals[srsStage];
}
The bug causes the function getSrsIntervalInHours to be called all the time with an undefined value for parameter level. because item.assignment does not have a level property. Then acceleratedLevels.includes(level) is always false because because undefined is not in the acceleratedLevels array. This happens to work correctly for regular levels. But for accelerated levels this is wrong and cause them to be treated as a regular level.
Most content is regular and not affected by the bug. For the two accelerated levels the bug does not cause the script to break. The only way to notice is to use the script on an item of level 1 or 2 with a filter where non accelerated delay is actually causing an erroneous filtering. This is a rare occurrence. This is why the problem went unnoticed for years.
Happy New Year @seanblue
I recall having seen a post of yours where you said you have no time for scripting and wouldn’t fix your scripts for this reason. Are you still in that state of mind? Does it mean you won’t maintain the Additional Filters anymore?
If you are OK with it I will take over the maintenance of Additional Filters. I will fork the script and maintain the fork. Are you OK with this? Please advise.
You can take it over if you want. In this case, you’re also welcome to open a PR into the existing github repo. You said it’s a simple change, so I can approve the change and then push it up to greasyfork.
This is simpler. Can you post a link to the github repo? I don’t find it in the OP.
Found the github repository. I have issued a PR. I am not good with github so I may have done it wrong. Please report any problem and I will fix it.
Uhh, I see the pull request in your fork, but you have to target the pull request to my original. I’m honestly not sure how to do that. 
Also, what’s the need for the download and update URLs?
I don’t know. These URLs are in the Greasyfork version but are missing in the github version. I thought you added tem to Greasyfork and forgot to add them to github.
When I tried to do that I didn’t have the rights to do this. I will try again.
It’s fine. It’s simple enough, I’ll just push up the change this weekend.
I think I got the pull request right now.
Greasyfork started adding the download and update URLs automatically. I don’t remember the reason. (Or maybe it was TamperMonkey??)
The week-end is over and the change hasn’t been pushed. Or at least Greasyfork doesn’t report it to me. Did you lack the time to push it up?
1 Like