[Userscript]: WaniKani Ultimate Timeline

I was using single backticks… And nothing else. I think box is double backticks, but I don’t remember.

OH.
I had both elements down there.
I’ll fix that. Thanks again!

EDIT: That worked. First it reappeared (moving the timeline up to the others), and then… moving the grid=“horizontal” line to where you have it… rather than immediately under the //(# of Reviews) line finally removed the horizontal lines.
You are a gentleman, and a scholar!

1 Like

hi,
im getting a bug when i try to refresh the homepage with ultimate timeline enabled. the popup never loads, and the console is full of errors, as seen below


the only addons i have loaded currently are the timeline and required framework.
edit: this seems to be an issue with the framework itself, rather than the ultimate timeline, sorry for posting this here. enabling just the framework gives no errors, but the error is given whenever a framework depended addon is enabled.

4 Likes

This is also happening to me

Same errors.
I use Safari with Tampermonkey.
Everything was OK just one or two days ago.

Happening with many scripts, probably a WaniKani issue.

1 Like

Yeah, likely some change that broke the framework.

1 Like

Same issue here, also using Safari with Tapermonkey

It looks like a CORS issue, judging by the errors that are coming up. So this isn’t an issue with the scripts or open framework so much as the API server. Tagging @viet and @oldbonsai to hopefully confirm and fix.

Access to XMLHttpRequest at 'https://api.wanikani.com/v2/subjects?updated_after=2019-08-01T21:00:26.103295Z' from origin 'https://www.wanikani.com' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource.
2 Likes

Ok. Rolling back an update. Sorry all.

15 Likes

That was quick. Glad to see such devotion even after hours.

4 Likes

Rollback should be done in five minutes or so.

15 Likes

Aaaaand we’re back! Thank you!

API looks to be fully working for me now.

Looking back, it looked like only some endpoints were affected, while others were fine. I can’t recall which ones were broken though; certainly subjects and review statistics, and I think maybe assignments too

2 Likes

Cheers, thanks!

Thanks for the info.

We’ll have to look at the changes we did that caused the issue. The intent of the update was to expand the CORS access to PATCH/POST/PUT endpoints. But it looks like we ended up just breaking things x_x.

12 Likes

We found the errors, tuned up our test suite, and deployed the fixed code just a couple minutes ago. Everything should be good to go, including the PUT/PATCH/POST endpoints.

8 Likes

Hey, I seem to recall a time with the old timeline where the points on the graph on the left would change depending on how many items you had for review… and scale appropriately. Was this still a feature (while keeping max_height the same)?

If not, could you help me turn it from what it is, to this:

image

And then if the number higher than 100 happens (I hope to never have that many reviews at one time ever again) either have the number on the left (old Timeline) or just 100+ (like 42+).

I saw code up at the very top including max_height…

},
y_axis: {
height: 100,
min_height: 80,
max_height: 300,
max_reviews: 0,
},

And thought perhaps changing “max_reviews” from 0 to 100 might do it, but honestly I was hoping to find somewhere that said 0,50,100,150 so I could just change those numbers to 0,25,50,75,100 …

Thought I asked you this before, this request has been on my mind for months. Just been busy/stressed with schoolwork.

Thanks a bunch for all that you do!

You can force the height in the settings to 100 right? If that’s not what you’re after I’m not sure what you mean.

If you open up the settings there are these options. Looks like you have it set to 150 and force. I believe I requested the former and you the latter, so that might be the request you were thinking of.

image

This has been my settings: image

Max Height (reviews) is how tall the graph will get maximum… not the number of reviews (maximum) displayed.

@Pep95 no, it’s not. Thanks though. To be more clear, I’m hoping for it to look more like what I’ve written in red in the first image… With steps of 25, 50, 75, and 100, so my teensy bars of 6-11 reviews are viewable.