[Userscript] Stroke Order Diagram

Ysekai · March 4, 2021, 8:55am

Yes I gave all access (by reinstalling it just in case)

Kumirei · March 4, 2021, 9:13am

If you go to the script’s settings in Tampermonkey, do you perhaps have it blocked under XHR security?

Ysekai · March 4, 2021, 9:34am

Thank you! I actually only had jisho.org on the whitelist! Then at the same time I was reading "Limited runtime host permissions might break some Tampermonkey features like script update, GM_xmlhttpRequest and others!" · Issue #640 · Tampermonkey/tampermonkey · GitHub because I had the '"Limited runtime host permissions might break some Tampermonkey features like script update, GM_xmlhttpRequest and others!" problem.

Cloudfront.net was added by right clicking on Tampermonkey, hover over “this can read and change site data” , select “on all sites”. I don’t remember which option was selected beforehand.

And I think when I reinstalled stroke order script earlier, only jisho.org access was asked (anyway I allowed everything earlier so that’s strange)

Kumirei · March 4, 2021, 9:37am

I think for most people it adds cloudfront automatically. I’ll see if I can add it explicitly in the script, though. I’ll add Jisho explicitly as well, so people don’t have to approve it

I assume this means it works fine, now?

Ysekai · March 4, 2021, 9:42am

Yes it works now! Thanks again

Kumirei · March 4, 2021, 9:45am

Updated the script with explicit permissions for those domains Thanks for helping improve the script for everyone else

Rover777 · March 13, 2021, 3:04am

this script has stopped working all of a sudden, am I the only one that has this problem?

Asaar · March 13, 2021, 3:07am

same, i though it was just me.

Rowena · March 13, 2021, 4:15am

Just checked - me too. I’m on a PC using Chrome.

Esther1972 · March 13, 2021, 5:22am

Me too. This was working perfect for me, and I loved it! Now it just doesn’t show up at all and I have tried uninstalling and reinstalling, clearing cache, allowing pop-ups, etc. and nothing. : ( Would love to have it working again!

Kumirei · March 13, 2021, 5:37am

@Rover @Asaar @Rowena @Esther1972 I’ll have a look at it when I get the time. I am working this weekend, though, so that might not be until Monday

Rowena · March 13, 2021, 6:22am

Thanks very much for maintaining this script, Kumirei-san.

Sinyaven · March 13, 2021, 1:57pm

I just tested this script and found two problems:

It tries to access http://jisho.org, but only the https version seems to work for me.
The WaniKani team seems to have changed the structure of the item pages, and the script does not find the place to insert the diagram.

This can be fixed by changing line 39 in the script from

var JISHO = 'http://jisho.org'

to

var JISHO = 'https://jisho.org'

and line 137 from

$(sectionHTML).insertAfter('#information')

to

$(sectionHTML).insertAfter('.span12 header')

@Kumirei Sorry for meddling in your script.

Mike_Nekoski · March 13, 2021, 2:24pm

Kumirei · March 13, 2021, 2:37pm

Thank you for looking into it! It’s not my script, I’m just maintaining it, so I’m happy to not have to mess with it

Asaar · March 13, 2021, 4:01pm

thank you so much @Sinyaven

Esther1972 · March 13, 2021, 6:38pm

Oh, that works great!

Thank you so much!!!

Kumirei · March 13, 2021, 7:09pm

The Greasyfork script has been updated with these changes

nyxqueenofshadows · March 14, 2021, 3:12pm

sorry, it’s still not loading for me and i’m not sure why? i’m kinda new to userscripts

prouleau · March 14, 2021, 3:23pm

The most probable cause of your problem is you don’t have the most recent version installed. You still have the old version that doesn’t work. You can try reinstalling the script afresh. Otherwise you may try the be patient. Tampermonkey will automatically update itself within a week.