@LiteracyFanatic nit: do you even need to compare against the current date? Why not just check for null in item.data.passed_at?
1 Like
You’re right. I guess I really overcomplicated things when only a three character change was needed.
2 Likes
Hello !
Sorry to be such a newbie 
how could I implement your patch to fix the current script ? Do I just need to copy paste inside the script like at the end ? thanks 
It’s a very small change, so you can fix it manually by searching for passed and changing it to passed_at. More generally, the command line program diff can be used to show all the changes between two versions of a file, say a.js and b.js. You can save this output to a file and use the patch tool to apply the changes necessary to transform your copy of a.js to b.js. When developers collaborate on larger pieces of code, they naturally pile up many such changes. There is another tool called git which is used to track and manage them. You can search for the names of these tools online to learn more if you’re interested (they likely are not installed on your computer by default). Like I said earlier, you can just make the change manually this time.
1 Like
Perfect it worked well thanks ! This sound interesting, I have seen some friends work on GItHub before but never learn how it works. Maybe I should investigate more in order to not be lost next time !
I’m currently using this script mainly for the critical review time feature. But I’ve discovered a conflict between this and the Keisei Semantic-Phonetic Composition script which is causing a minor problem in how both lessons and reviews are displayed.
For some reason it affects the spacing between sections as per my screenshot in the link below. If I disable Integrated Dashboard Overhaul the spacing reappears.
Anyone know how to resolve it?
I’ve sort of fixed my own problem with this script conflict through a bit of trial and error (I’m not a coder).
I commented out the line that starts with
section { margin: 0 0 20px !important; }
and the correct spacing has come back in lessons and reviews.
For some reason this script has suddenly stopped working at all for me. I use it for the critical review feature and the lessons and reviews breakdown info.
Tried disabling all other scripts except WKOF and still nothing. Also tried with the Compatibility Mode enabled but no joy.
I’m guessing the OP is no longer supporting this but does anyone else use it?!
EDIT: Took screenshots from the Chrome inspection window. Hopefully someone understands what this means and why it would suddenly take objection to it:
EDIT 2:
@Kumirei @prouleau Hope you don’t mind me tagging you since you’ve posted in this thread before but looks like the OP is no longer active. Maybe the issue above means something to you?
I don’t know why it’s causing an error, but by just trying some things I found out that it’s one of the dependencies that is causing it. I don’t think that the script is actually using that one anyway, so you can just remove it.
In the beginning of the script you just need to remove the last line with // @require (the one before @license.
1 Like
Genius! This seems to have fixed it.
I’m now running a rather heavily modified version of this script (I previously had to take another part out) but as long as it keeps doing the two features I like then I’m happy.
Just one thing is it now seems to have removed the gap above the lessons and reviews button on the main page from the Progress Percentages bar add-in that I also have. Not really a big deal but not sure why it would have caused that.
With it running it looks like this:
If I disable the script it looks like this:
… which is what it used to be like.
No idea why this script would be messing with the margins like that.
1 Like