[Userscript]: Double-Check (Version 2.x)

[Elina145]

It happens to radicals for me too. The first few seem to work after I refresh the page/log in and out but then it stops working again.

[LupoMikti]

I see. I only had the one so I didn’t get to test it more. Good to know.

[Vendetta1881]

yeah, I’ve encountered the same problem. hopefully it’ll be fixed soon. can’t really study much without the dopamine of items hitting new SRS stages lmao

[LupoMikti]

Ok, I’ve figured out the issue. For rfindley when you see this, the issue is that WaniKani changed how they do the hiding and unhiding of the srsContainerTarget. Instead of a hidden attribute being directly applied, data-hidden is used instead and has its value toggled.

Changing all instances of srsContainerTarget.hidden in the script to srsContainerTarget.dataset.hidden fixes the issue (the use of dataset.hidden is how it is in the quiz-header controller’s updateSRS function).

[rfindley]

Thanks for the investigation and solution! I’ve updated the script as you described. Please let me know if there are any issues.

I’m trying to stay 100% focused on my contract work right now, so every bit of effort from the WK community in finding and fixing script issues is warmly appreciated. You guys are fantastic! Thanks again, @LupoMikti!

[TreyE]

Hi there— Reviews SRS Preview needs the same fix. Below is a diff I’ve tested.

(Do you maintain these scripts on a source code repository? I don’t see them on GitHub, so I’m assuming either no, or you use another one. If you do, I’d be happy to send a pull request instead.)

--- Wanikani Reviews SRS Preview.user.js.bak	2024-01-17 13:36:41.000000000 -0500
+++ Wanikani Reviews SRS Preview.user.js	2024-01-17 13:37:42.784811811 -0500
@@ -65,14 +65,14 @@
         let srs_info = JSON.parse(quiz_queue.subjectIdsWithSRSTarget.innerText);
         let srs_stage = (srs_info.find((info) => info[0] === subject_id) || [0,undefined])[1];
         if (srs_stage === undefined) {
-            quiz_header.srsContainerTarget.hidden = true;
+            quiz_header.srsContainerTarget.dataset.hidden = true;
         } else {
             let srs_stage_name = ['','Apprentice 1','Apprentice 2','Apprentice 3','Apprentice 4','Guru 1','Guru 2','Master','Enlightened'];
             quiz_header.srsIconUpTarget.hidden = true;
             quiz_header.srsIconDownTarget.hidden = true;
             quiz_header.srsTextTarget.innerText = '('+srs_stage_name[srs_stage]+')';
             quiz_header.srsContainerTarget.dataset.wentUp = '';
-            quiz_header.srsContainerTarget.hidden = false;
+            quiz_header.srsContainerTarget.dataset.hidden = false;
         }
     }

[rfindley]

@TreyE,

Heh… I don’t even remember writing that script. Anyway, I’ve posted an update. Thanks for the tip!!

With the exception of Open Framework, I maintain them solely on GreasyFork.

[DuoLingo]

Today I got the above message. Looking up this message showed issues from several years ago, so is this legit and if so, why am I getting this only now (been using double-check for about a year)?

I then checked my extensions for tampermonkey which I originally allowed for only two sites. But somehow it now shows access to ‘all sites.’ How can this happen without me changing it?

I changed it back to wanikani.com but I can’t find where you had specified what sites to include if I want to limit tampermonkey access. I remember there were two sites. What is the other site that I need to include?

Thanks for your script; LOVE IT!!!

[LupoMikti]

I don’t believe this message has anything to do with Double-Check. It’s just a Tampermonkey permission thing. As for how it can have permission for all sites suddenly, if it’s Chrome I wouldn’t at all be surprised if it allows the extension to update with expanded permissions and no user confirmation. At least with Firefox, if an extension requests new permissions or permission for access to new sites, it is not allowed to update until you manually confirm this. But if it is the case that Chrome does this as well, then perhaps you never actually had it restricted in the first place.

The blacklist for Tampermonkey can be found in the Settings under the Security and BlackCheck sections (you must change your config mode to Beginner or Advanced to see these sections). This is what the defaults look like for me:

If you really want to limit Tampermonkey, I think you can change the Page Filter Mode to Whitelist and then it will only execute scripts on Whitelisted domains/pages. But I do not know if this is the same as restricting where Tampermonkey itself runs.

I believe it has been the case that Tampermonkey requires the all sites permission as a core permission for a long time now. Indeed this seems to be the case for any script manager as both Greasemonkey and Violentmonkey have the same core permission. It seems that if one is the type of person who does not like to give an extension the all sites permission, then use of a script manager is not for them.

[rfindley]

I agree with @LupoMikti.

blacklist.tampermonkey.net is a safe and known URL, and the blacklist capability is a good security feature, so I’d recommend leaving it enabled and allowing the requested permission…

[DuoLingo]

Thanks for your detailed response

@LupoMikti

But if it is the case that Chrome does this as well, then perhaps you never actually had it restricted in the first place.

I am using Chrome and I AM one of those who don’t like to download loads of stuff or freely give access to these apps; so I definitely did restrict sites for Tampermonkey to access.

Fortunately, I found the list of sites for Tampermonkey to access so I can use my WK scripts (it was still there on my Brave browser). So I changed the site access on Chrome to those listed on Brave and I just completed my reviews with no problems (even made a correction ).

Hopefully I won’t experience any problems, but THANK YOU so much for your response. I’m bookmarking it just in case I need it in the future

OOPs! It seems like I have to click on tampermonkey every time I log back in to let it access WK! No problem, I can live with that!

[DuoLingo]

Thanks for your confirmation of what LupoMikti said!

[Fact]

Is this working for people at the moment?? This is the first user script I’ve found to just not work immediately, is there something I’m missing?

[prouleau]

It works for me.

What do you mean by does not work immediately? Do you expect something visible on that dashboard? If this is the case it is normal that nothing shows up on the dashboard. The effect is to enable hotkeys in the review page. For example if you press backspace you get to change and reenter you last answer.

Another way to check this script is working is to click on the gear icon in the upper left corner of the review page. This gives you access to the settings of the review scripts. Double Check should show up in this list,

[Fact]

i dont think its showing up correctly on my end, ill have to investigate some more. It’s definitely installed and enabled so I’m not sure what it is.

[prouleau]

I don’t see the gear icon so hat at least is odd. Did you install the Open Framework as the first script in Tampermonkey? Go to the Tampermonkey dashboard and check whether Open Framework is at no 1 position. If not move it there and see if this resolve your problem.

[Fact]

here’s my setup, I disabled the other stuff for testing. maybe its cached or something, I’ll try resetting it.

[Fact]

lol clearing everything, logging in and out worked. thanks for the troubleshooting.

[LupoMikti]

Double check does not work during lessons. It is for reviews only (referring to your first screenshot)

[jontsuba]

I’m afraid that the bug that doesn’t allow to input “+” and “-” neither in synonyms nor in notes is back.