It isn’t just Firefox. I’m on Chrome and I get this too. Happens either on a lesson, or when I go to an item’s page. The console is showing that the request is being blocked by client:
I’ve got an issue where the KanjiDamage mnemonics are visible when I go to the detailed kanji page, but not during the lessons. I’m using Violentmonkey on Firefox, the console shows this:
TypeError: right-hand side of 'in' should be an object, got null
reviewMn https://www.wanikani.com/lesson/session:230:17
updateThings https://www.wanikani.com/lesson/session:198:21
observer</< https://www.wanikani.com/lesson/session:206:25
forEach self-hosted:262:13
observer< https://www.wanikani.com/lesson/session:204:21
I tried disabling uBlock and Privacy Badger, but that didn’t help. Does anyone else have any suggestions?
The meaning section is all around the place. This happens because of conflicting ids “meaning”.
I dared to fix it and forked the script. Also I took liberty to slightly change the style to match lessons and reviews: KanjiDamage mnemonic is a child of Meaning section, not a sibling.
I remembered reading KanjiDamage a good several years ago, but then I installed this script and looked up a few Kanji I originally had trouble with the first time. Then I got this.
hey, great script. Ive been having the same issue as here. script wont run on lessons, but on the detailed kanji page. i get below error. im using tampermonkey on firefox and siabled anything that could be blocking it, such as ublock etc
i picked this from the console, but i have no idea what im doing
Uncaught (in promise) TypeError: mlocation is undefined
tms_51f2bd55_f46c_436c_a3d1_213c42b18e09 moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/userscripts/KanjiDamage mnemonics for WaniKani.user.js?id=51f2bd55-f46c-436c-a3d1-213c42b18e09:144
l https://cdn.wanikani.com/assets/v03/lesson/application-430217ba60848b0ce37def6a409cbce2f61c88d5e90b562e620cf57d17cae578.js:25
add https://cdn.wanikani.com/assets/v03/lesson/application-430217ba60848b0ce37def6a409cbce2f61c88d5e90b562e620cf57d17cae578.js:25
ready https://cdn.wanikani.com/assets/v03/lesson/application-430217ba60848b0ce37def6a409cbce2f61c88d5e90b562e620cf57d17cae578.js:25
tms_51f2bd55_f46c_436c_a3d1_213c42b18e09 moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/userscripts/KanjiDamage mnemonics for WaniKani.user.js?id=51f2bd55-f46c-436c-a3d1-213c42b18e09:114
tms_51f2bd55_f46c_436c_a3d1_213c42b18e09 moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/userscripts/KanjiDamage mnemonics for WaniKani.user.js?id=51f2bd55-f46c-436c-a3d1-213c42b18e09:155
s eval:4
<anonymous> moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/userscripts/KanjiDamage mnemonics for WaniKani.user.js?id=51f2bd55-f46c-436c-a3d1-213c42b18e09:1
<anonymous> moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/userscripts/KanjiDamage mnemonics for WaniKani.user.js?id=51f2bd55-f46c-436c-a3d1-213c42b18e09:1
<anonymous> moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/userscripts/KanjiDamage mnemonics for WaniKani.user.js?id=51f2bd55-f46c-436c-a3d1-213c42b18e09:156
<anonymous> moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/userscripts/KanjiDamage mnemonics for WaniKani.user.js?id=51f2bd55-f46c-436c-a3d1-213c42b18e09:158
s eval:4
t eval:3
E_u eval:4
create eval line 2 > Function:67
create eval line 2 > Function:69
c eval line 2 > Function:7
s eval:4
i eval line 2 > Function:5
s eval line 2 > Function:5
v eval:13
v eval:13
s eval:4
t eval:12
s eval:4
h eval:12
h eval:12
send eval:13
s eval line 2 > Function:5
setTimeout eval line 2 > Function:6
run eval line 2 > Function:8
runListeners eval line 2 > Function:7
anonymous eval line 2 > Function:70
v eval:13
tms_51f2bd55_f46c_436c_a3d1_213c42b18e09 moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/userscripts/KanjiDamage mnemonics for WaniKani.user.js?id=51f2bd55-f46c-436c-a3d1-213c42b18e09:155
s eval:4
<anonym> moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/userscripts/KanjiDamage mnemonics for WaniKani.user.js?id=51f2bd55-f46c-436c-a3d1-213c42b18e09:1
<anonym> moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/userscripts/KanjiDamage mnemonics for WaniKani.user.js?id=51f2bd55-f46c-436c-a3d1-213c42b18e09:1
<anonym> moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/userscripts/KanjiDamage mnemonics for WaniKani.user.js?id=51f2bd55-f46c-436c-a3d1-213c42b18e09:156
<anonym> moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/userscripts/KanjiDamage mnemonics for WaniKani.user.js?id=51f2bd55-f46c-436c-a3d1-213c42b18e09:158
s eval:4
t eval:3
E_u eval:4
create eval line 2 > Function:67
create eval line 2 > Function:69
c eval line 2 > Function:7
s eval:4
i eval line 2 > Function:5
s eval line 2 > Function:5
v eval:13
v eval:13
s moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/content.js:92
s moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/content.js:92
n moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/content.js:93
(Async: setTimeout handler)
setTimeout moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/content.js:105
processMessage moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/content.js:109
72 moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/content.js:113
init moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/content.js:93
s eval:4
t eval:12
s eval:4
h eval:12
h eval:12
send eval:13
s eval line 2 > Function:5
setTimeout eval line 2 > Function:6
run eval line 2 > Function:8
runListeners eval line 2 > Function:7
anonymous eval line 2 > Function:70
v eval:13
s moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/content.js:92
s moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/content.js:92
send moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/content.js:93
E moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/content.js:116
processQueue moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/content.js:88
r moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/content.js:95
(Async: EventListener.handleEvent)
g moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/content.js:96
72 moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/content.js:97
72 moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/content.js:117
72 moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/content.js:117
t moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/content.js:1
<anonym> moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/content.js:2
<anonym> moz-extension://875d41a5-b708-41a2-a0e9-4b4cb65c302d/content.js:2
inject resource://gre/modules/ExtensionContent.jsm:575
InterpretGeneratorResume self-hosted:1482
AsyncFunctionNext self-hosted:692
having the same issue, using chrome and tampermonkey. The mnemonics didn’t show up on lessons, but it shows up on reviews and individual kanji page. Already tried disabled all scripts and tried using firefox and edge still didn’t work
@morczubel@hilmyaas WK has recently updated the lesson page, and that change breaks this script. If you want, you can try out my fork of this userscript: Install from my fork
The forked version is also more secured against XSS attacks, but this change was probably unnecessary because Kanji Damage is likely trustworthy, and the fetched pages are actually stored on https://grenzionky.github.io, which I assume is under the control of the script author. The forked version only handles a small subset of HTML tags, so some stuff might be missing.
EDIT: Updated my fork – it now handles all occurring HTML tags, except for <table>-related tags (which seemed unnecessary) and the one embedded YouTube video on the page for 派 (which seems to have been removed from YouTube anyway).
I have turned on compatibility mode and that made it work fine! thanks for the tip.
Are there any blatant downsides to this? i run a few scripts so i think im a candidate for it (I usually slap like 400 mods ontop of my skyrim aswell lmao)
The only downside I can think of is that the compatibility mode only delays the breaking change, and one day this change will also reach the compatibility mode (at least that is how I understand it – you can read the official post about the compatibility mode here).
I think the intended use of the compatibility mode is:
Notice that some of your installed userscripts don’t work anymore.
Report the problem in the respective threads.
Activate the compatibility mode so that you can still use the scripts while the script authors hopefully try to fix them.
Every once in a while, check if the scripts were fixed, and if they were, disable the script compatibility mode so that you are using the up-to-date version of WK.
The script author actually accepted my 6 months old github pull request two weeks ago. However, they did not update the script available at OpenUserJS, so the version linked in the OP is still broken. Considering the slow response time, I’m wondering if I should even bother them to also update their OpenUserJS script.
Anyway, I did not publish my version of this script in a new thread because of the pending pull request. And partly also because I have never used KanjiDamage but have heard that it might contain some controversial mnemonics, so I would have preferred to not have the script published under my name just to avoid any potential problems. But now that the pull request took forever and did not even fix the OpenUserJS version, I’m wondering if maybe the best solution really is to resort to creating a new thread.
And thank you for cleaning up the list of userscripts.