Oh I thought you only had to write the reading but I see it now. Thank you very much. 
Hi all, I’ve just built a first implementation of the “persistent notification” feature some of you suggested:
https://www.dropbox.com/s/25gn7hq08pdqdx7/WaniKaniMobile-1.15.0pre0-pn0.apk
The notification subsystem is difficult to test, because it largely depends on events that are outside of my control. In addition there’s a lot of possible customizations. On top of it, I had almost no time to test it, so use it at your own risk :)
Persistent notification is disabled by default; if enabled, and:
- There are pending reviews, tapping on it will open the review page
- Else, lessons are waiting, tapping will open the lessons page
- Else, tapping will open the forum page.
This release contains also many improvements in the way radicals and kanji progress is displayed.
I have tried the new release and the notification is great< my only problem is that it doesn’t always update itself. For example this morning it said something like “Three hours till next review”; when i checked later the time didn’t update and it still said 3 hours. It updated only after I opened the app and refreshed.
sackboy97 said... I have tried the new release and the notification is great< my only problem is that it doesn't always update itself. For example this morning it said something like "Three hours till next review"; when i checked later the time didn't update and it still said 3 hours. It updated only after I opened the app and refreshed.Right. I completely forgot to implement the code to update the notification :)
Besides I have no idea of how to do it: I need to register an event handler that is called when the notification window is shown, so I can calculate the remaining time and update the text. Does anybody know how can I do this?
As a temporary fix, here's an APK that simply displays the next review time as an absolute timestamp:
https://www.dropbox.com/s/npmg8tap7iasrul/WaniKaniMobile-1.15.0pre1.apk
It also contains the feature suggested by @matzenegger (show number of current level's available kanji/radicals)
s84606 said...Well, I have no coding knowledge, but from what I see the problem may be that once the app is closed, the process is killed too; so maybe making it permanent could solve the problem? I may (and probably am) completely off with it, but oh well :Dsackboy97 said... I have tried the new release and the notification is great< my only problem is that it doesn't always update itself. For example this morning it said something like "Three hours till next review"; when i checked later the time didn't update and it still said 3 hours. It updated only after I opened the app and refreshed.Right. I completely forgot to implement the code to update the notification :)
Besides I have no idea of how to do it: I need to register an event handler that is called when the notification window is shown, so I can calculate the remaining time and update the text. Does anybody know how can I do this?
Thanks for the update by the way!
I’m not sure how this new notification system works, or why it is better than what we had before, but I’ve got some bugs.
First, I didn’t opt in the anything, but my notifications are behaving differently.
When I look at my notifications, the two reviews and lessons notifications keep removing and adding themselves, and when I want to remove them, they come back even though I had the update time set to 10 minutes.
Next, I never clicked on either notification. I went to my home sceen and clicked on the app and it took me to my lessons page. Perhaps I was there last time I left the app though.
Next, when I’m in the app and I click the home button, the app gets sent to the “all running apps” view instead of going to my home. It isn’t doing it at the moment, but it was doing it for a few times after I noticed it took me straight to my lessons.
I don’t see why persistent notifications would be a good thing, and hopefully the app isn’t continuously communicating with the WK servers. I don’t see any option in the app to opt out either.
Just wanted to drop by and express my gratitude for the implementation of the input filtering I suggested. I did 600+ reviews today that I had backlogged and using the app feels better than ever. Thanks for listening to our suggestions.
I think the persistent notifications zapped my battery. It died much earlier than usual and I hardly used my phone at all.
SamusAranX said...First, I didn't opt in the anything, but my notifications are behaving differently.That's unintended, and most probably a bug. If you don't check Settings/Persistent notifications, notifications should behave exactly as before. If you check it, then you will always have exactly one notification at a time.
When I look at my notifications, the two reviews and lessons notifications keep removing and adding themselves, and when I want to remove them, they come back even though I had the update time set to 10 minutes.Ok. This is the big problem. I'm trying to reproduce it but it's quite difficult. Just to make things clear: do you actually have reviews and lessons, when it's showing them?
Next, I never clicked on either notification. I went to my home sceen and clicked on the app and it took me to my lessons page. Perhaps I was there last time I left the app though.I've not changed anything in this scenario, so I suppose you were on the lessons page when you left them. That would be expected behaviour.
Next, when I'm in the app and I click the home button, the app gets sent to the "all running apps" view instead of going to my home. It isn't doing it at the moment, but it was doing it for a few times after I noticed it took me straight to my lessons.Hmm.. might be a side effect of the app running at full CPU.
I don't see why persistent notifications would be a good thing, and hopefully the app isn't continuously communicating with the WK servers. I don't see any option in the app to opt out either.While I try to reproduce/fix this, just to make your phone usable again, you can:
- Try enabling persistent notifications: this uses a different algorithm that may not be affected by this bug
- Downgrade to the latest app store version. Depending on the OS version, you might not be able to downgrade; if so, please tell me and I'll give you an APK with greater version code but without persistent notification.
https://www.dropbox.com/s/7jmmx6h921283o0/WaniKaniMobile-1.15.0pre1-dbg0.apk
It shall behave exactly like 1.15.0, but it also logs some debugging information I need. To see the log messages you can use e.g. aLogCat, and filter by the tag "WKM". You should be able to save those messages and publish them on the forum (or send them directly to me). Make sure the file you are sharing is filtered by "WKM" and does not contain other apps' messages (they might contain sensitive information). After that, if the app continues draining the battery, you can downgrade to 1.14.1 with this APK (the version code is larger that the previous APK, so it should install ok).
https://www.dropbox.com/s/mn4qd9mthfpjapu/WaniKaniMobile-1.14.1-118.apk
Thanks!
I had a bunch of lessons and a bunch of reviews. I rebooted my phone and I finished all my reviews earlier this morning. The lessons notifications aren’t doing anything weird. Also, I had just exited vacation mode a couple of days ago, and hadn’t done anything until this morning.
I’ll have time to help debug next weekend.
nice
Hello,
This is a really great app. Thanks for writing and sharing it.
Would you consider adding an option to show whether a kanji is asking for the ON or the KUN reading during reviews.
In the same way as this this user script.
/t/Wanikani-KunOn-101-Kunyomi-or-Onyomi-instead-of-Reading-No-longer-supported/3883/1
Thanks again.
Howard.
hoovard said...Would you consider adding an option to show whether a kanji is asking for the ON or the KUN reading during reviews.Hi, thanks for the suggestion. I had a look at the script, and it seems fairly simple to integrate. I'll try incorporating it into the app and, unless I encounter some unexpected problem, I'll release it in an experimental APK.
In the same way as this this user script.
/t/Wanikani-KunOn-101-Kunyomi-or-Onyomi-instead-of-Reading-No-longer-supported/3883/1
s84606 said... Hi, thanks for the suggestion. I had a look at the script, and it seems fairly simple to integrate. I'll try incorporating it into the app and, unless I encounter some unexpected problem, I'll release it in an experimental APK.Oh, fantastic. Thanks very much.
H.
hoovard said...Ok, here's the APK:s84606 said... Hi, thanks for the suggestion. I had a look at the script, and it seems fairly simple to integrate. I'll try incorporating it into the app and, unless I encounter some unexpected problem, I'll release it in an experimental APK.Oh, fantastic. Thanks very much.
https://www.dropbox.com/s/z0kggttdf3h0bdt/WaniKaniMobile-1.15.0rc0.apk
Seems to work reasonably well, but needs some testing..
s84606 said...I have tested it a bit and the progress bars aren't working correctly. I just started level 11 and did the initial review of the radicals and kanjis and the progress bar is showing that I have gurued the 100% already.hoovard said...Ok, here's the APK:s84606 said... Hi, thanks for the suggestion. I had a look at the script, and it seems fairly simple to integrate. I'll try incorporating it into the app and, unless I encounter some unexpected problem, I'll release it in an experimental APK.Oh, fantastic. Thanks very much.
https://www.dropbox.com/s/z0kggttdf3h0bdt/WaniKaniMobile-1.15.0rc0.apk
Seems to work reasonably well, but needs some testing..
Never mind figured out the change in the progress bar.
Thanks
s84606 said...Thanks for making the apk so quickly.hoovard said...Ok, here's the APK:s84606 said... Hi, thanks for the suggestion. I had a look at the script, and it seems fairly simple to integrate. I'll try incorporating it into the app and, unless I encounter some unexpected problem, I'll release it in an experimental APK.Oh, fantastic. Thanks very much.
https://www.dropbox.com/s/z0kggttdf3h0bdt/WaniKaniMobile-1.15.0rc0.apk
Seems to work reasonably well, but needs some testing..
I'm not sure if I will be able to test it for a while, I just got sent abroad for work (not Japan unfortunately)... also I'm not sure how to install an apk but I'm sure google will provide the answer.
Sorry I can't try it right away.
H.
Would it be possible to add the “Part of Speech” userscript?
sackboy97 said... Would it be possible to add the "Part of Speech" userscript?I'll try: from a quick look I did not notice anything problematic, except its size.. it's really huge :)
Thanks so much for adding the ON/KUN functionality. My phone just updated the app and it is in there.
It works great. Awesome.
Thanks again.
H