Hey, I’m having an issue that I think might be with the script, but I’m not 100% certain. I can reproduce it with most of my other scripts off, but I do have Reorder Omega enabled because it would be terrible to test this without it, given the stack of 700 reviews I’m still whittling down (From 1500, halfway there, woo). I do see that you have Script Compatibility mode as required, and I do have that enabled at least.
At least during reviews, the reading mnemonic section seems to have its formatting stripped away on items with an on’yomi reading that are converted.
If you’d like I can test further with only this script, but it might take a bit for me to lottery onto an on’yomi kanji reading.
Hmm, yeah that’s probably caused by this, as this script does go into this content to modify it to katakana.
I’ll investigate it and see if I can fix. Thanks for the heads up.
I tried to fix this, and think I found something, I’m testing currently and will release it on tampermonkey if I don’t see any issues.
If you want to test it yourself before then, you can edit the script by changing the line that contains
var reviewItemInfoDropDownReadingLocator =‘#item-info-reading-mnemonic span:lang(ja)’;
Just tried it out on my machine, and looks to be working fine now. Hope your testing goes just as well.
As a side note, being out of kanji reviews for another hour and only having vocabulary to test it on… I don’t think I’ve thought about how many words are just “If you know the readings of your kanji you’ll know how to read this as well” until having to go look for one that isn’t. At least there’s the header and hint section of that block being fixed to sanity check that I didn’t somehow mess something up putting that in until I hit one.
Yeah, this is why I usually take a few days to test. It can take quite a lot of reviews before you hit a combo that I failed to foresee while coding.
Thanks for this! I like being able to know what reading I’m using, and Katakana helps. However, it seems this script breaks the WaniKani Pitch Info userscript. It may be that the Pitch Info userscript will need updating to support Katakana being present
I tried changing the UserScript order in Tampermonkey, but that did not work
Hmm, that is strange. This script should only impact kanji, and I assume pitch info is only valid for vocab? It’s certainly possible they interfere anyway, but it is odd.
As @Harald1 said, the pitch info script only shows info for vocab items. Your screenshot is of a kanji item, so there is nothing wrong in that screenshot. I just tested the two scripts together and didn’t notice any problems.
Think I might’ve just run into one of those combos if you haven’t already, which I was thankfully able to reproduce in extra study for the screenshot (I didn’t think to take a screenshot on the review page with all my scripts enabled, and I straight up forgot when I turned everything but this off to make sure it still happened).
For the item 場, here’s the normal view of the reading information:
And here is the view with only Katakana For Onyomi (and Reorder Omega, for the extra study I used to reach it):
Hmmmm. I wish I could reproduce this on my browser. I guess there’s some issue with the fact that there’s a kanji in the hint?
Thanks for the report, I’ll look into it.
Edit: Think I found the issue but then I hit the wrong button while doing a live edit in tampermonkey and destroyed my changes right before I was going to test them.
@Xandrez192 new beta version. More changes this time, full script in paste: RE:#6900e687 - aa1f1224
I’ve tested it a bit and it seems to work, but as before I’ll wait a few days to see if anything pops up. Thanks for reporting the issue with the previous beta.
I’ve been using it just fine for a while with compatibility mode off.
Yeah, somehow it seems to work decently even without compatibility mode on, but I expect there are some issues and I just haven’t noticed.
Doesn’t seem to work consistently anymore after they retired compatibility mode for good. It works sometimes on Review section, doesn’t work at all on Kanji section, seeing a bunch of different errors in the console
The test part of reviews seems to work as well as it always did. Lessons work poorly.
The Kanji section does seem to be entirely broken(although it is at least not crashing the page). I rarely use the non review / non lesson parts of the site, so I hadn’t noticed.
I’ll have a look.
Well, I made a fix for lesson page, although the quiz dropdown is still not showing katakana. Unfortunately, while the script is valid, greasyfork will not accept it due to the script needing to poll for wk to finish loading. As far as I can tell, this is a technical issue on greasyfork, but it is very unclear when, if ever, they are going to fix it.
There’s probably a workaround on my end, but it seems like it would require a lot of refactoring.
Meanwhile, here’s the script paste for those who don’t mind manual updates // ==UserScript== // @name WaniKani Katakana For On'yomi // @author... - b16c3745
New year, new version.
Note that this script now depends on Installing Wanikani Open Framework
The script should now display on’yomi correctly during lessons, although the dropdown during lesson reviews is still wip.
Thanks for this. Just installed and it’s working fine.
Doesn’t work in item pages and listing pages. Perhaps because Wanikani is gradually removing jQuery?