Everything looks good there. The extension should only activate on the sessions page due to that line, and not on the main page.
What extension are you using on Firefox?
these:
Rather, which Firefox extension is it? GreaseMonkey? TamperMonkey? ViolentMonkey? Or another one? If I’m going to try to reproduce the issue, I’ll need to know which extension is being used.
But the list of scripts you’ve provided is also valuable to see if one of them is impacting things as well, so that’s good to have.
1 Like
I’m sure the @evandcs will confirm, but that looks like Tampermonkey in the screenshot.
2 Likes
TamperMonkey
This script looks broken due to the latest UI update. Any chance someone will be working on a fix?
2 Likes
I’ll look into it.
Been mostly in bed lately due to a cold.
(Not quite better yet… But I’ve been in bed for almost 24 hours, so I’m getting some computer time in before heading back to bed.)
I’ll need to read up on what others are saying about changes. I wrote this script before I knew much about Javascript, so I have no idea what’s behind my usage of $.jStorage (I just looked at other extensions when writing mine), and it doesn’t seem to work for me anymore.
1 Like
A few changes later, I think I have the script updated.
As per usual, you’ll want to take note of any configuration changes you’ve made directly to the source code, as you’ll need to set them again after updating.
Updated script:
One thing that concerns me is that while testing, my script only ran maybe one in five page loads. If anyone else has this issue when doing reviews, let me know and I can look into it.
2 Likes
Works great, thank you!
1 Like
No problems on my end regarding page loads.
Quick question though:
const quiz_element = document.querySelector('div[class=quiz]');
I think quiz should be quiz-input, no? Otherwise it’s inserted at the top of the page.
1 Like
That’s so weird. When I did all my testing, it put it in the correct place. But now it’s at the top of the page.
It should indeed be quiz-input. I’ll have to get that updated when I have a chance later today.
1 Like
I’ve pushed version 1.0.0 to the GreasyFork repository.
Aside from the fix mentioned in the prior post, this adds a ☰ menu icon to the top-left corner of the review page. Click this to access settings. (Have thoughts on a better placement/method for accessing the settings? Let me know!)
With this update, settings are now stored in the browser’s local storage rather than the userscript’s code:
1 Like
Perhaps it’s better to use the unified script menu other scripts use?
1 Like
I’ll have to look into that. I was certain I’d seen something like that but didn’t know where to access it from. (I’ll admit that my current implementation was partly trying out making a config window open on the page, a functionality I’ll use on other projects.)
1 Like
wkof.include('Menu');
wkof.ready('Menu').then(setup);
function setup(){
wkof.Menu.insert_script_link({
name:'kanji_review_vocab_list', // Used for id tag
submenu:'Settings',
title:'Kanji Review Vocab List',
on_click:open_settings
});
}
There’s also a Settings module for creating Settings dialogs. There’s some documentation on [github].
You’ve got a decent settings dialog already, though, so it may or may not be worth changing.
1 Like
If we’re thinking about potential settings, I actually quite like having it at the top of the page. Less chance I mouse over and reveal it when I’m moving around on the page.
Also, you may consider adding it to the settings menu that many scripts already use. I assume this uses Open Framework or some similar script to accomplish, so if you don’t want to make it dependent I would understand that. If you keep the current menu icon though, you might want to add a little space to the right to make it match. At least on my screen, this is how it looks currently (with my other scripts):
Edit: Oh, I see people beat me to the punch.
1 Like
I’m encountering an example of a kanji where the list isn’t showing up. It seems to load instantly (or be pre-loaded) on certain kanji, but this one, for example, shows nothing, even though there are 5 or so vocab words using the kanji in the database:
Thanks so much for this!
Seems like an excellent userscript to have when I can already comfortably read almost everything in my reviews and I’m just trying to reinforce associations between seldom-seen (or easily confused/mistaken) kanji and their respective vocabulary.
It also seems like the location for where it unhides the vocabulary is very generous.
Sorry about the awful screenshot, there’s no easy native way to screenshot mouse position apparently.
Thank you very much for this script, Christopher! I do recommend it!