These should both be fixed now!
1 Like
It was actually due to WK changing the reviewQueue from (in compatibility mode) containing complete review data to only containing ids, and since I was looking for ids these were mapped to undefined. The activeQueue is the same, however, so those 10 items were processed correctly
@Kumirei, I took a look and I’m getting a few more errors when starting review sessions. This one seems to reoccur the most:
After that this one seems to be the most common one.
I assume both are caused by race conditions of some kind, as the variables don’t exist yet when the script is running but are present if I manually check the console after the page is loaded.
1 Like
The first one I think should be fine to just check if it is defined. If there’s no currentItem there’s nothing to prioritize anyway.
The second one was a bit puzzling, because I thought it was part of the WKOF Core module, but I was wrong, it’s part of the Apiv2 module, so I just had to make sure to include the Apiv2 module, even if only to get the user’s level
(Hopefully) Fixed in 0.1.10:
- Don’t prioritize reading or meaning when there’s no item in queue
- Properly include user module
2 Likes
The update fixed some of the errors, the sorting is still off though. The initial item is now always correct, however after that the order is still essentially random, and back-to-back mode doesn’t seem to be working either. I’m not getting any direct errors anymore though. I assume the initial queue is sorting correctly now but after that something is going wrong when the next item is being selected.
1 Like
I just pushed a fix for that (0.1.11). I got momentarily confused and messed up some conditionals.
2 Likes
The update doesn’t seem to fix it for me yet though, I assume it’s due to a similar problem as what I’m experiencing with the sorting itself. From what I can tell the next item isn’t updated properly after one prompt is submitted, so instead WK’s default behavior seems to be selecting the next prompt instead, which means it’s a random reading/meaning prompt from the first 10 items in the queue. I’m having trouble pinpointing what exactly is going wrong though.
2 Likes
Hold on, I think I can replicate it
1 Like
@BIsTheAnswer turns out I could not
I don’t suppose you’re using any other script that modifies the queue?
Are you still on compatibility mode?
Is this happening for reviews or extra study?
What actions do you have in the active preset?
1 Like
Back-to-back doesn’t work for me either for reviews.
Tried with and without other scripts enabled.
Tried with and without script compatibility mode.
Tried with different presets (usually I have ‘none’).
1 Like
Just to confirm, do you have 0.1.11 installed?
Librewolf, FF clone (v98.0)
(on Arch btw )
1 Like
I see. It’s not working properly on Firefox
edit: found the issue. In trying to make the Math.random hack more specific I have broken it for other browsers. Should have known.
1 Like
Ok, let’s see if 0.1.12 works any better for you
3 Likes