It’s noted in the search section. I know most people won’t read it, and I’ve been thinking of adding an exact search toggle. That will make it more obvious.
I would refrain from tagging searches “winning” or “losing”, as it isn’t the case of not returning results but more the case of what is shown and whether that is what the user /learner wants.
From a learner’s perspective, it’s fine to return inflections, for example 泣く could return 泣いた、泣かない. But how about なく？ What should that return? I don’t recall anyone saying there is a problem with jisho.org when they provide 20 entries for なく, or other forms of あう when searching for 遭う, but some find that issue with immersion kit.
On a side note, Sudachi is used, not MeCab.
I agree there are some cases where a different parser or a different search algorithm would make sense, and in fact I have added quite a number of hard mappings on top of the Sudachi parser. I guess if you were to sit someone down for full time summer job and go through the 10k most common vocab parsing that would be helpful to the site.
It’s more of Kanji choice, actually. Since this is a Kanji learning site, it can matter.
Also, I didn’t really test the UserScript, so I can’t tell if it would fail, but I don’t think 「」 is a part of the script.
I would consider making PR. It’s in /resources/*/*/data.json's word_base_list key, perhaps. I also notice that I don’t really directly need to use the API. Just look at the sound key, and adding your static base URL is enough.
That being said, it is also possible that PR is accepted or not, but I can still make my search engine.
I think it’s fine to return results with とりあい for 取り合い, とにかく for 兎に角, or はずかしめ and 恥ずかしめ for 辱め. I know some might want the exact search result returned, but that is a compromise I think that is better for learning purposes.
I’m not responsible for the userscript. For the game gengo textbook, in the “extra examples” section, some items use regular search, some exact search, and some are hand-picked from the database. That is a better approach.
sorry if this has been answered before, i’ve done a quick scan and can’t find it
sometimes when new titles get added, all of the other titles which i’d selected in that list get deselected? even though i’d not done anything or even gone into the settings at all. so this time, in the ghibli list everything was fine. the other titles were selected as i’d left them, and the new ones were where they should be. in the (tv) anime list, the new ones had come in, but all of the other ones had been deselected. last time i remember the same thing happening to both lists, not just the one like this time
is this a common thing or is it just me again, sorry if this has been brought up before
Hello Good question! I’ll be honest, I don’t know how to preserve settings between updates, and I justified it by saying at least if the title choices are lost, this will prompt people to open settings and see the new titles! Not very user friendly, I know. I’ll do more tests before the next update to see if I can avoid it.
I just came to the forum after thinking that Wanikani context sentences are a bit bland and poorly implemented and stumbled upon this amazing script! Thank you so much for creating this, it really breathes new life into my lessons! And of course also a big thank you to the creators and contributors of immersionkit.com, which I wouldn’t have discovered otherwise.
Hey, this is awesome! I have a few critical suggestions , ranked by order of importance :
Anime chosen for filter - their sentences will be at top, but the rest will be displayed lower. this way I can avoid having no example sentences at all because I’ve filtered too much. usually I just want the animes that I like be on top, but having something is better than nothing in cases where my specific anime does not have that vocab word
option for anime example sentences to be on top when opening info on card . i.e i got a card wrong and press F to see details - anime context will be at the top.
option for card info to open automaticlly because I want to hear the recordings when I review .
option to give a “like” to a specific recording you like so it will play back during reviews or atlist be on top of other anime sentences when you open the additional info.
have an option to remove anime sentences with one word, or with the word put in brackets - often times subtitles have certain words in brackets, and these words are not actually part of the sentence but actually describe the scene . i.e words in brackets are not actually voiced.
have an option to mark an anime sentence , then export the list of anime sentences marked into downloadable audio files so I can make anki cards out of them .
I have already created a pull request for fixing the problem with the unnamed tab (but this fix still keeps the Anime Sentences section as a separate tab). @psdcon, if you want to place the Anime Sentences section in the Context tab, the append() has to be changed into appendSubsection(). You now also have the option to change notify() into notifyWhenVisible() – both of them work, but have small differences (currently only during the lesson quiz).
The callback function will be called once the user opens the item info. At this point, the Context tab is still closed and its content is not in the DOM, so when you try to append your section, Item Info Injector outputs a warning in the console that your section could not be injected. However, your section is cached and appended automatically once the user opens the Context tab, so everything should still work. ↩︎
The callback function will be called once the user expands the Context tab. In this case, appendSubsection() works without problem and you don’t get a warning. However, if the user collapses and then expands the Context tab once more, the callback function is also called again – so your section gets recomputed every time the tab is expanded.
So in the case of Anime Sentences, the main difference between these two options is: with notify(), Anime Sentences gets loaded even if the user opens the item info without ever looking into the Context tab, while notifyWhenVisible() will delay the loading until the user actually opens the Context tab, but this also means that the user then has to wait until the data has been fetched from Immersion Kit before they can see the sentences. ↩︎
Sentences not showing for any item.
Simply saying “No sentences found.”
Wondering if Immersion Kit was down, or…?
It was working before, so I don’t believe it on my end.
Also, I use an extension called Dark Reader that gives “night mode” to every website. This causes ‘greyed out’ items to become visible. (I’d post a pic, but can’t due to there being no sentences lol)
I guess this would be more of a suggestion - Perhaps a way of implementing the ‘greying out’ that’s unaffected by changing background colors. I know of other ‘dark mode’ scrips, and wonder how they affect the greying out.
‘Night mode’ absolutely saves my eyes.