I can’t commit on a timeframe and I don’t think chatGPT can do it.
Thanks to all the hard work of those before me. I fixed it with trusty ol’ ChatGPT. Want me to share it somehow?
Make a pull request on github
It’s nice that it’s good enough for you, but I can see several issues from that screenshot that aren’t the colors that I believe others should be aware of, especially prouleau before accepting any code changes.
The item tiles themselves are styled wrong, or rather, styled how they used to be, by being too small and too rounded, and then they also have all of the characters inside the tile off center horizontally. These tiles wouldn’t match up with current Wanikani styling. And then the 90% border isn’t visible enough, you can’t even tell it’s there until you click on the image to enlarge it. The margin or padding on the entire component needs to be adjusted so it is not so close to the bottom of item inspector. There’s an unsightly gap of one tile at the right due to wrapping, so the style of the item lists themselves needs to be updated to handle this.
This is just more or less a list of things that would need to be addressed, not a criticism of you specifically Raito. Thank you for your enthusiasm to help.
1 Like
i started doing it by hand, but i can’t test it properly until i do my lessons later today
i don’t actually use breeze dark, but hopefully i can get it working for people
2 Likes
Please make a pull request on github when you feel ready. I will take a look at it.
1 Like
Thank you! You have a sharp eye for detail! I didn’t notice these errors, but I wonder if some of it was due to me zooming out the webpage to capture more of my dashboard. Here it is in regular 100% zoom. Let me know if those errors persist. If so, it will be nice to see @straille ‘s model when they’re all finished up. From what they’ve posted so far, their model already looks quite a bit more polished. Thanks everyone!
2 Likes
this seems to be the best i can figure to do about the gap from wrapping the items
i’m just not sure it’s an adequate solution and maybe it should be left as it was
2 Likes
Yeah. Leave it at how it was. It is cleaner that way.
1 Like
Version 4.2.0 is available - Please download it at the link on the top post
This implements support for dark themes Breeze Dark and Elementary Dark.
1 Like
oh, i guess you didn’t care for my version 
that’s fine because i don’t use dark themes
i’m also not sure i want to update in case it messes up my positioning 
1 Like
I would have cared for your version if you had completed in time for me to use it.
This version will not mess your positioning. But if you don’t use a dark theme there is not advantage to upgrade. I think Tampermonkey will automatically upgrade eventually.
i did create a pull request, i dunno if you saw
i had published it, but noticed some mistakes, so set it back to draft to finish it and left it like that in case anything else was messed up
I didn’t see your pull request. Sorry about that. I thought gitbub would send me an email if there is a pull request and it didn’t.
dang, oh well
1 Like
Thank you!
1 Like
I can send you emails (it did when you sent me one for example) but you’d probably have to make sure your notification settings are set up correctly.
Edit: as a side note, there is still merit in using the CSS variables even if you don’t use a dark theme, because any theme not just dark ones can use those to recolor. For example, a userstyle I like that someone here made is this pastel light theme which uses the variables to recolor some things. I’ve been thinking about potentially making my own personal Catppuccin userstyle for wanikani which would support all 4 flavors, one of which is a light theme, and those variables would be essential. Userstyles would not need to write in support for userscripts if the scripts use wanikani css classes and variables in the first place.
1 Like
CSS variables are good, but sometimes I have a need that doesn’t have a corresponding variable. Then there is no choice but to go on my own.
1 Like
this is true
i had a hard time coming up with a variable for the little progress nuggets that would work on default and also look okay on breeze dark
my own theme has variables for dark grey, light grey, white, green, yellow, blue, pink, and purple
also red and black, but i don’t think i use those anywhere
everything else i just convert to one of my own variables
2 Likes
The level progress indicators have wanikani variables available, so I’d say use those
And then the userstyles can concern themselves with overriding those (in this case I’d would have to make a request to breeze dark to override these, but by using them in the userscript, I as the script author no longer need to concern myself)
There are hundreds of variables but I understand not having ones for something more specific. But with so many, my bet is that there’s one that will work well enough.